Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

impl: global registration context #220

Merged
merged 6 commits into from
Sep 27, 2023
Merged

impl: global registration context #220

merged 6 commits into from
Sep 27, 2023

Conversation

qzhuyan
Copy link
Collaborator

@qzhuyan qzhuyan commented Sep 26, 2023 •
edited
Loading

intro. global registration context.
Use c_ctx wrap global registration handle.

prepare to get the list of listeners/connections under registration.

github-advanced-security[bot]
github-advanced-security bot found potential problems Sep 26, 2023
View reviewed changes
c_src/quicer_nif.c Fixed Show fixed Hide fixed
qzhuyan
qzhuyan commented Sep 26, 2023
View reviewed changes
c_src/quicer_reg.c Outdated Show resolved Hide resolved
qzhuyan
qzhuyan commented Sep 26, 2023
View reviewed changes
c_src/quicer_nif.c Outdated Show resolved Hide resolved
qzhuyan
qzhuyan commented Sep 26, 2023
View reviewed changes
c_src/quicer_nif.c Outdated Show resolved Hide resolved
@coveralls
Copy link

coveralls commented Sep 26, 2023 •
edited
Loading

Pull Request Test Coverage Report for Build 6315416084

  • 91 of 116 (78.45%) changed or added relevant lines in 7 files are covered.
  • 2 unchanged lines in 2 files lost coverage.
  • Overall coverage decreased (-0.05%) to 83.033%
Changes Missing Coverage Covered Lines Changed/Added Lines %
c_src/quicer_listener.c 6 7 85.71%
c_src/quicer_connection.c 8 11 72.73%
c_src/quicer_nif.c 25 29 86.21%
c_src/quicer_reg.c 48 65 73.85%
Files with Coverage Reduction New Missed Lines %
c_src/quicer_config.c 1 83.5%
c_src/quicer_listener.c 1 84.78%
Totals Coverage Status
Change from base Build 6297714086: -0.05%
Covered Lines: 3137
Relevant Lines: 3778
💛 - Coveralls

github-advanced-security[bot]
github-advanced-security bot found potential problems Sep 26, 2023
View reviewed changes
c_src/quicer_reg.c Fixed Show fixed Hide fixed
@qzhuyan qzhuyan marked this pull request as ready for review September 27, 2023 07:44
@qzhuyan qzhuyan changed the title Dev/william/g r ctx imply. global registration context Sep 27, 2023
@qzhuyan qzhuyan changed the title imply. global registration context impl: global registration context Sep 27, 2023
thalesmg
thalesmg approved these changes Sep 27, 2023
View reviewed changes
c_src/quicer_nif.c Show resolved Hide resolved
c_src/quicer_reg.c Show resolved Hide resolved
c_src/quicer_reg.c Show resolved Hide resolved
@qzhuyan qzhuyan merged commit 42e896d into emqx:main Sep 27, 2023
26 checks passed
@qzhuyan qzhuyan deleted the dev/william/G_r_ctx branch September 27, 2023 13:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thalesmg thalesmg thalesmg approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@qzhuyan @coveralls @thalesmg